fix: keep SSH known_hosts temp file alive until repository cleanup#150
Closed
creydr wants to merge 1 commit into
Closed
fix: keep SSH known_hosts temp file alive until repository cleanup#150creydr wants to merge 1 commit into
creydr wants to merge 1 commit into
Conversation
The known_hosts temp file was deleted via defer in getSSHClientOptions, which runs before the SSH connection is established in CloneRepository. This caused host key verification to fail silently when known_hosts data was provided. Move temp file lifecycle management to Repository, which cleans up all temp files in its Cleanup method alongside the cloned directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
known_hoststemp file created ingetSSHClientOptionswas immediately deleted viadeferbefore the SSH connection was established inCloneRepository, causing host key verification to silently failRepository.knownHostFileand cleaned up byCleanup()deferinCloneRepositoryensures cleanup on error paths where noRepositoryis returned to the caller